Organize dScripts #814
Merged
Organize dScripts #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitespace Remove parent scope Remove parent scope from initial setter Remove debug Remove helper programs
Xiphoseer
previously approved these changes
Nov 3, 2022
|
Actually, can you look into this CI error: https://github.com/DarkflameUniverse/DarkflameServer/actions/runs/3384677223/jobs/5622793276#step:5:947 ? |
aronwk-aaron
approved these changes
Nov 3, 2022
|
Beat me to it 😭 thanks so much for this! |
Xiphoseer
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organize dScripts so everything is not just in one folder and is also organized how they were in live. Also allows for even easier maintenance.
No functionality of scripts is changed with this PR.
Currently have tested that this compiles on Ubuntu 20.04.
All CMakeLists.txt files were generated through a Python script. Some manual editing was done to add in some scripts that failed to get added to source file lists.