fix: use encoding on latin1 strings from cdclient #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use template function Update GeneralUtils.cpp consolidate duplicate code Update GeneralUtils.cpp Update BinaryIO.cpp compilers
aronwk-aaron
approved these changes
Dec 24, 2024
DarwinAnim8or
approved these changes
Dec 24, 2024
Xiphoseer
requested changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested that cafe corner no longer shows up with the incorrect text and now shows up as cafe corner.
@Xiphoseer said to "just hook up an iterator to the utf8 encoder" so I did just that by reading the string from binary as u8 (because if you try and convert a std::string it uses signed characters which utf8 did not like) and then run that through the exact same function that handled the utf16 to wtf8 conversion.