Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow SQLite database backend #1663

Merged
merged 48 commits into from
Dec 18, 2024
Merged

feat: allow SQLite database backend #1663

merged 48 commits into from
Dec 18, 2024

Conversation

EmosewaMC
Copy link
Collaborator

@EmosewaMC EmosewaMC commented Dec 4, 2024

Adds SQLite as a backend database for server data.
Updates various components to work with the new file structure and migration setup.
Consolidate migations into 1 initial one for sqlite.
Adds migration for mysql migrations to migrate them to the new filepath.
Ensure backwards compatibility with MariaDB setups.
Ensure default from now on is SQLite.
Update README with the new setup instructions.
Send exes from subprocesses to the background so players are not interrupted in gameplay by a new window every world transfer.
Adds CppSQLite3 binds for sqlite_int64 types.
New migrations are moved and placed in the correct directories.

Tested that all queries are functional as before and that gameplay is unchanged.
There are known issues with windows and how it handles shutting down the server which I will address in a future PR as I already know of a fix for this for single player servers specifically.

@EmosewaMC
Copy link
Collaborator Author

#1665

@EmosewaMC
Copy link
Collaborator Author

update migration runner, add back mysql files then we're done

@EmosewaMC
Copy link
Collaborator Author

#1674

Xiphoseer
Xiphoseer previously approved these changes Dec 10, 2024
resources/sharedconfig.ini Outdated Show resolved Hide resolved
aronwk-aaron
aronwk-aaron previously approved these changes Dec 12, 2024
aronwk-aaron
aronwk-aaron previously approved these changes Dec 17, 2024
jadebenn
jadebenn previously approved these changes Dec 17, 2024
Copy link
Collaborator

@jadebenn jadebenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick aside, lgtm

@DarkflameUniverse DarkflameUniverse deleted a comment from jadebenn Dec 17, 2024
Xiphoseer
Xiphoseer previously approved these changes Dec 17, 2024
Copy link
Contributor

@Xiphoseer Xiphoseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the cmake removals

.env.example Outdated Show resolved Hide resolved
Jettford
Jettford previously approved these changes Dec 17, 2024
Copy link
Collaborator

@Jettford Jettford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o7 legend

lgtm

@EmosewaMC EmosewaMC merged commit a60865c into main Dec 18, 2024
4 checks passed
@EmosewaMC EmosewaMC deleted the sqlite branch December 18, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants