-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow SQLite database backend #1663
Conversation
…sages fix deleting model remove unrelated changes Update GameMessages.cpp
update migration runner, add back mysql files then we're done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick aside, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the cmake removals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o7 legend
lgtm
e3c9c71
Adds SQLite as a backend database for server data.
Updates various components to work with the new file structure and migration setup.
Consolidate migations into 1 initial one for sqlite.
Adds migration for mysql migrations to migrate them to the new filepath.
Ensure backwards compatibility with MariaDB setups.
Ensure default from now on is SQLite.
Update README with the new setup instructions.
Send exes from subprocesses to the background so players are not interrupted in gameplay by a new window every world transfer.
Adds CppSQLite3 binds for sqlite_int64 types.
New migrations are moved and placed in the correct directories.
Tested that all queries are functional as before and that gameplay is unchanged.
There are known issues with windows and how it handles shutting down the server which I will address in a future PR as I already know of a fix for this for single player servers specifically.