feat: re-write leaderboards again and fully remove mysql dependency outside of database #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sages fix deleting model remove unrelated changes Update GameMessages.cpp
EmosewaMC
requested review from
DarwinAnim8or,
jadebenn,
Xiphoseer,
Wincent01,
aronwk-aaron and
Jettford
Xiphoseer
previously approved these changes
Dec 4, 2024
aronwk-aaron
previously approved these changes
Dec 4, 2024
EmosewaMC
dismissed stale reviews from Xiphoseer and aronwk-aaron
The merge-base changed after approval.
aronwk-aaron
approved these changes
Dec 6, 2024
Xiphoseer
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be merged after #1660 and #1661
tested that all leaderboards show summaries in the same way as prior
tested that new scores update the values in the table or add one if one did not exist
the pages stuff was removed because the client has no functionality to actually request pages of the leaderboard. it can put it in the GM but nothing sets it to anything aside from 0 and 10