Fixed Misspelling for Treasure in PetComponent files #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmosewaMC
reviewed
Jun 18, 2024
|
As far as refactoring goes this was pretty simple, can you let me know more about what the pr is doing that they are working on? Maybe they could refactor it as well? Just curious |
|
I'm all for this - it's going to be a pain to bring my PR up to date anyway |
jadebenn
approved these changes
Nov 18, 2024
EmosewaMC
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically title. Original pet treasure variables were Tresure, which was a misspelling. All I did was rename each instance to Treasure, and changed the associated methods as well.
Tested by opening server and digging pet treasures to ensure nothing was conflicting. Pet treasure digs perform as intended still.
motivation: clean up code a bit