feat: Observers and deferred implementations #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
approved these changes
May 25, 2024
aronwk-aaron
previously requested changes
May 25, 2024
EmosewaMC
changed the title
DarwinAnim8or
approved these changes
Jun 4, 2024
|
Nice to see the gameprogrammingpatterns.com influence ;) Big fan of observers so this looks great |
jadebenn
dismissed
aronwk-aaron’s stale review
gonna toss this in another PR as per discord chat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to add helper classes for observers as well as a way to optionally defer/override an implementation of a method or action.
These classes would in the future help with server-side modding. The observer class is very standard as observers go. Usually you would relay on something like a strategy pattern to switch between implementations — do not think that is quite the right solution here.
In the event of modding through library loading at runtime, they could set their observers and overrides through these classes.
In this pull request are examples of how these classes could be implemented into existing classes. These could be excluded if that would be preferred.