chore: Change LDFFormat to use BitStream references #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How has this been tested? |
|
@EmosewaMC Ran unit tests, per usual. If you'd like to wait on an in game run before approving, I plan to do that on the various branches tomorrow where I try to hit the affected features to make sure everything looks right in-game. |
This was referenced Feb 25, 2024
|
Please test them in-game. I wont be approving code that hasn't been run in-game to check that it works. |
|
Combined all the bitstream reference branches into one local branch and ran the game for about an hour where I went from AG to NS to GF following the main questline. Seems stable to me. |
aronwk-aaron
approved these changes
Feb 25, 2024
EmosewaMC
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduction of raw pointers