feat: achievement vendor and vendor feedback #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make transaction result more useful
Cleanup and fix some calls in gamemessages
Patch Auth
|
Lot 13732 (TEST COMMENDATION VENDOR) now works since it's no longer hardcoded to be 13806 |
Xiphoseer
approved these changes
Feb 25, 2024
jadebenn
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hardcoded achievement vendor logic to now work with any achievements vendor
Check if a player should be able to buy an item from the achievement vendor
Log cheat detection for trying to buy items that can't be bought
Better feedback when trying to buy or sell something and can't
Tested that buying from normal vendors and achievement vendors works