chore: Remove anonymous namespace from GeneralUtils.h

[jadebenn]

Anonymous namespaces in header files do not actually prevent access to the enclosed functions in corresponding .cpp files and having one here is therefore pointless

[EmosewaMC]

alternatively this could just be moved to a namespace called priv, that way Parse_ doesn't show up in hints. though it would be preferable to have the hidden function be called _Parse as we have done elsewhere in GeneralUtils

[jadebenn]

alternatively this could just be moved to a namespace called priv, that way Parse_ doesn't show up in hints. though it would be preferable to have the hidden function be called _Parse as we have done elsewhere in GeneralUtils

Any identifier with a leading underscore is technically reserved by the standard, which is why I opted for a trailing underscore instead.

[jadebenn]

Also, since these are explicit template instantiations, I think it should be possible to move them to the cpp file and hide the implementation functions that way, so I might try that.

[jadebenn]

Actually, no, I don't think that would work. The TryParse function is not explicitly instantiated and would need access to Parse_ in the function body, so even if I moved Parse_ to the source file, I'd still need to provide a declaration in the header, meaning it would still be accessible through any included header file. I don't think I can move TryParse out either, though perhaps that could be achieved via extern template (which I understand poorly).

[EmosewaMC]

alternatively this could just be moved to a namespace called priv, that way Parse_ doesn't show up in hints. though it would be preferable to have the hidden function be called _Parse as we have done elsewhere in GeneralUtils

Any identifier with a leading underscore is technically reserved by the standard, which is why I opted for a trailing underscore instead.

You're thinking of double underscore. Single underscore is fine so long as a capital letter does not follow.

[jadebenn]

alternatively this could just be moved to a namespace called priv, that way Parse_ doesn't show up in hints. though it would be preferable to have the hidden function be called _Parse as we have done elsewhere in GeneralUtils

Any identifier with a leading underscore is technically reserved by the standard, which is why I opted for a trailing underscore instead.

You're thinking of double underscore.

They're both reserved in C++ according to what I've read: https://devblogs.microsoft.com/oldnewthing/20230109-00/?p=107685

[EmosewaMC]

That page is talking about global scope which does not apply here.

[jadebenn]

No, though I was mistaken in my recollection to you. Identifiers with a leading underscore and a capital letter are reserved everywhere. So _parse would be fine outside of global scope, but _Parse would technically be a standard violation (even though it would probably compile and run without issue).

[EmosewaMC]

How has this been tested?

[jadebenn]

I've compiled with the #ifdefs commented out and tried the game a little. I haven't done much because none of the underlying logic has been touched, so I didn't think more than a cursory check was necessary.

[EmosewaMC]

Code at the very least should be run and tested in some capacity, either through unit or integration, as untested code paths may cause issues during runtime; just good practice to hop in game and hit your code path a bit or write a unit test