chore: General cleanup roundup #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmosewaMC
reviewed
Feb 3, 2024
|
I will wait until you finish adding in random changes to review this. |
|
All the changes I have added to this since the initial commit have been to respond to your requests. |
EmosewaMC
reviewed
Feb 4, 2024
|
looks like I finally got the instantiation problem fixed. should be ready to go unless you all have any other feedback here |
EmosewaMC
reviewed
Feb 10, 2024
EmosewaMC
previously approved these changes
Feb 10, 2024
EmosewaMC
previously approved these changes
Feb 10, 2024
|
EDIT: nope |
|
aaaand false alarm. We're good. |
aronwk-aaron
previously approved these changes
Feb 10, 2024
jadebenn
dismissed stale reviews from aronwk-aaron and EmosewaMC
via
b8b8d92
|
...wow, they really require re-review for fixing merge conflicts? |
|
annoying. |
EmosewaMC
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out unrelated changes from #1442. General cleanup of things I noticed while I was working on the TryParse branch.