chore: remove all raw packet reading from chat packet handler #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n lenght Was doing this on other places, but not the main one
and general chat packet cleanup
Xiphoseer
previously approved these changes
Jan 13, 2024
aronwk-aaron
requested review from
Xiphoseer,
Wincent01,
EmosewaMC and
Jettford
Xiphoseer
previously approved these changes
Jan 13, 2024
EmosewaMC
reviewed
Jan 13, 2024
EmosewaMC
reviewed
Jan 14, 2024
Add GM level handeling
EmosewaMC
previously approved these changes
Jan 14, 2024
aronwk-aaron
force-pushed
the
remove-chat-raw-packet-reading
branch
from
e22d646 to
a19dac3
Compare
EmosewaMC
approved these changes
Jan 14, 2024
Xiphoseer
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and general chat packet cleanup
Tested that things still work