Implements all the pickup scripts #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwk-aaron
force-pushed
the
pickup-scripts
branch
from
50ae176 to
6cc0a1e
Compare
Testsed to make sure they work Tested to make sure existing script works still killing it immedialtely is live accurate, the timer was not accurate
aronwk-aaron
force-pushed
the
pickup-scripts
branch
from
6cc0a1e to
37fe935
Compare
@EmosewaMC brought this up, but I had already done it this way lol |
add speed buff
|
note, armor and speed buff don't work due to something in the skill. the skills are casts and the effects play but repair and speedboost are not given. out of scope for this PR. but noting for me to look at later |
|
Has thos broken the imagination pickups on the ag monument? Those were working fine before |
|
Ah armor and speedboost specifically nvm |
EmosewaMC
reviewed
Apr 9, 2023
split speed out to use target as caster fix armor skill
EmosewaMC
reviewed
Apr 9, 2023
EmosewaMC
approved these changes
Apr 12, 2023
DarwinAnim8or
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested to make sure they work
Tested to make sure existing script works still
killing it immediately is live accurate, the timer was not accurate