Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templated plugins' root namespace can be invalid #25

Closed
JamJar00 opened this issue Apr 19, 2020 · 0 comments
Closed

Templated plugins' root namespace can be invalid #25

JamJar00 opened this issue Apr 19, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JamJar00
Copy link
Member

When generating a plugin in a folder with a hyphen, for example, the root namespace should be normalised to a valid C# namespace name and should not contain the invalid characters.

I imagine title casing, removing all symbols/whitespace (not underscore) and exposing this as a new template variable would suffice quite nicely:

my-plugin -> MyPlugin
My amazing plugin -> MyAmazingPlugin
@JamJar00 JamJar00 added bug Something isn't working good first issue Good for newcomers labels Apr 19, 2020
@GuilhermeStrice GuilhermeStrice mentioned this issue Apr 21, 2020
Merged
GuilhermeStrice added a commit to GuilhermeStrice/darkrift-cli that referenced this issue Apr 21, 2020
@GuilhermeStrice
Correctly implements DarkRiftNetworking#25
7865510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamJar00