Simulate submit clearer responces #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xjimmy
requested review from
KillariDev and
MicahZoltu
and removed request for
KillariDev
KillariDev
approved these changes
Aug 10, 2023
Comment on lines
+22
to
+23
| error?: Error, | ||
| success?: { |
There was a problem hiding this comment.
here the type should be either error or success
{ error: Error } | { success: { .. } }
There was a problem hiding this comment.
Kinda annoying to refactor that out, so I'll add it as low priority issue
| </div> | ||
| <div class='flex gap-2 items-center'> | ||
| <span class='w-16 text-right'>Gas Used</span> | ||
| <span class='rounded bg-background px-2 py-1 font-mono font-medium'>{state.value.value.firstRevert.gasUsed} gas</span> | ||
| <span class='bg-black px-2 py-1 font-mono font-medium'>{state.value.value.firstRevert.gasUsed} ETH</span> |
| <span class='rounded bg-background px-2 py-1 font-mono font-medium'> | ||
| {'error' in state.value.value.firstRevert ? String(state.value.value.firstRevert.error) : 'Unknown'} | ||
| </span> | ||
| <span class='bg-black px-2 py-1 font-mono font-medium'>{'error' in state.value.value.firstRevert ? String(state.value.value.firstRevert.error) : 'Unknown'}</span> |
There was a problem hiding this comment.
can we get rid of casting to String?
| </div>) | ||
| if (outstandingBundles.value.error) return <SingleNotice variant='error' title='Error Sending Bundle' description={<p class='font-medium w-full break-all'>{outstandingBundles.value.error.message}</p>} /> | ||
|
|
||
| const chainIdString = provider.value ? provider.value.chainId.toString(10) : '-1' |
There was a problem hiding this comment.
why are we assuming -1 as the string if we don't know? Shouldn't this be undefined, or "1" if we want to assume mainnet
| export const BLOCK_EXPLORERS: { [chainId: string]: string } = { | ||
| '1': 'https://etherscan.io/', | ||
| '5': 'https://goerli.etherscan.io/' | ||
| } |
There was a problem hiding this comment.
Can we also have Sepolia support?
There was a problem hiding this comment.
I don't believe we have a flashbots proxy for Sepolia.
Co-authored-by: KillariDev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44