Tweaking error messages and supporting IDbConnection implementations … #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that return a DbCommand.
|
Extending Nick's error messages with some suggestions. Addresses: #757 |
|
Fixed merge, yanking in cleaner create call :) |
NickCraver
added a commit
that referenced
this pull request
Apr 4, 2018
…#986) * Better error messages for .*Async methods when not using DbConnection Perhaps in v2 we move these to DbConnection itself ratherr than IDbConnection for the extensions to eliminate the case, but that's breaking...for now we can at least throw a better error. See #757 for details. * Tweak errors to allow open IDbConnections and those generating DbCommands Same checks but a bit more lenient with more specific messaging. * Tweaking error messages and supporting IDbConnection implementations … (#987)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that return a DbCommand.