Change to GetAll to allow the usage of a nullable type in T when T is an interface… #933 #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an interface: further change to check if val == null and if so then don't try to assign it as a property value.
… interface. (effectively the same change as the previous change to GetAll.)
|
Can you please add a test for this to ensure we don't regress? |
NickCraver
reviewed
Mar 7, 2018
| if (val == null) continue; | ||
| if (property.PropertyType.IsGenericType() && property.PropertyType.GetGenericTypeDefinition() == typeof(Nullable<>)) | ||
| { | ||
| var genericType = property.PropertyType.GetGenericArguments()[0]; |
There was a problem hiding this comment.
Since .GetGenericArguments() allocates an array every time, instead use: Nullable.GetUnderlyingType(property.PropertyType) to do this much cheaper. Same below :)
…ype in T when T is an interface.
Added in tests for GetAndGetAllWithNullableValues and GetAsyncAndGetAllAsyncWithNullableValues.
Added comment to identify which issue the test relates to.
Adjusted variable names in GetAndGetAllWithNullableValues and GetAsyncAndGetAllAsyncWithNullableValues.
|
@NickCraver I realised that I missed including the async Get & GetAll methods. I've added the additional code to those methods and have added a couple of tests. I'll admit that this is the first time I've used tests (I'm such an amatuer!!) and so while I think they are adequete, I'm not certain of that. Hopefully it's all up to scratch now but if not, please let me know. |
|
@JaseRandall looking awesome, thank you so much for your first contribution! Excellently done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in response to an issue that I raised:
Basically I had DateTime? and was using an interface so that I could use the change tracking in Dapper.Contrib.
Without this modification, the code throws
OR
depending on whether the value from the (SQLite) database has a value or is null.
My suggested change:
checks for null and if so, continues;
otherwise if the type is nullable, it obtains the underlying property and assigns the value to the underlying property;
otherwise assign the value to the property as per the original code.