Make DapperRow implement IReadOnlyDictionary<string, object> #913
Conversation
|
|
||
| IEnumerable<string> IReadOnlyDictionary<string, object>.Keys | ||
| { | ||
| get { return this.Select(kv => kv.Key); } |
There was a problem hiding this comment.
possibly return table.FieldNames; ? although this would expose the field-names to abuse... slightly probematic; oh, and this array might be over-sized? hmmm, probably just ignore me
There was a problem hiding this comment.
edit: yeah, this (my code, not yours) also wouldn't take dead values into account; probably best to leave it alone
There was a problem hiding this comment.
Not a bad idea. I pretty much copied this from the existing IDictionary implementation, however so it really might be best to leave alone, for the sake of consistency.
(The only difference in the implementation is me skipping the .ToArray() at the end because for this interface it is enough to return an IEnumerable)
|
|
||
| IEnumerable<object> IReadOnlyDictionary<string, object>.Values | ||
| { | ||
| get { return this.Select(kv => kv.Value); } |
There was a problem hiding this comment.
possibly return values;, although similar concerns to Keys - probably best to leave this "as is", too!
|
Merging in :) |
.NET 4.5 Introduced
IReadOnlyDictionary<string, object>which is kind of a subset ofIDictionary<string, object>. This interface is really useful especially in immutable object models. However, for legacy reasonsIDictionarydoes not inherit fromIReadOnlyDictionaryunfortunately.This pull request makes the internal DapperRow class implement IReadOnlyDictionary<string, object> so we can simply pass a row into an API taking that kind of parameter, without the performance penalty of copying the row into a new Dictionary.