added firebird support

[pdesterlich]

added firebird sql adapter to allow record insert and key retrieving

[brart]

Works fine, tested it a bit. You just seem to have forgotten the Async class.
I do somewhat require this, but I don't know how to push something to a pull request. I can create my own pull request if you don't mind.

[pdesterlich]

You're more than welcome to create your pull request providing async support too.
I'm not using async (yet), so i only changed the part i use and i created a pull request just in case someone had the same problem.

[mgravell]

that looks pretty awesome; one bit of feedback: when I wrote some very similar code in the core of dapper, some folks (correctly) noted that the use of interpolated strings *could* hypothetically be abused on a compromised server to do very very bad things. Of course by that note: if you're already compromised you're kinda screwed anyways! I need to do a review to see how much we are/aren't using interpolated strings generally to assess whether this is meaningful feedback (it would be silly to criticize this if we used it extensively every where else in the code)

…

On 1 Dec 2016 10:39 a.m., "Phelipe de Sterlich" ***@***.***> wrote: added firebird sql adapter to allow record insert and key retrieving ------------------------------ You can view, comment on, or merge this pull request online at: #651 Commit Summary - added firebird support File Changes - *M* Dapper.Contrib/SqlMapperExtensions.cs <https://github.com/StackExchange/dapper-dot-net/pull/651/files#diff-0> (33) Patch Links: - https://github.com/StackExchange/dapper-dot-net/pull/651.patch - https://github.com/StackExchange/dapper-dot-net/pull/651.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#651>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABDsOtYibJeA1lppPsTGFcfDsMSd4BYks5rDqPegaJpZM4LBO-R> .

[NickCraver]

@mgravell It's used in the other adapters, so I'm for taking this as-is. I agree we should clean them all up though. I'll make a note for the v2 push to do so.

[say25]

It seems that FB Async was added in a7ff0b3