Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for #555 #558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Temporary fix for #555 #558

wants to merge 2 commits into from

Conversation

SelvinPL
Copy link

Registering CancellationToken with DbCommand.Cancel will allow
cancellation even with synchrouns DbReader.Read

SelvinPL added 2 commits July 12, 2016 14:57
Registering CancellationToken with DbCommand.Cancel will allow
cancellation even with synchrouns DbReader.Read
@NickCraver NickCraver added the v3.0 Changes awaiting the next breaking release label Jan 28, 2017
@NickCraver NickCraver modified the milestone: v2.0 Jan 30, 2017
@NickCraver NickCraver changed the base branch from master to main June 20, 2020 13:26
@NickCraver
Copy link
Member

First, thank you for raising this up and identifying the areas. Unfortunately, this one is a bit more nuanced, and required breaking API changes to handle before. But some of that is being addressed in #1590 - the approach there is to opt-in via CommandBehavior, but in vNext we want to globally address this across all APIs and really solve it for all cases. Marc's doing some work there now, but it's all generators so PRs against current code won't translate well before vNext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.0 Changes awaiting the next breaking release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants