-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A full CoreCLR/DNX friendly conversion #407
Conversation
Massive! :) |
Fixed missing check for explicit key in Contrib GetaAync()
This eliminates the dual solutions and brings Contrib into the project.json fold. - Tests are ported to xUnit though SQLite is disabled on DNX due to Issue #375 (Interop loads fail in the VS runner and params are busted regardless). - Projects are consolidated down to what's currently possible with project.json. - Contrib moved to: Dapper.Contrib and Dapper.Tests.Contrib (so tests appear at the end, no other reason vs. Dapper.Contrib.Tests) - EF moved to: Dapper.EntityFramework(.StrongName) - Rainbow moved to: Dapper.Rainbow - SqlBuilder moved to: Dapper.SqlBuilder - Packages are removed since it's not current-tooling friendly to keep them (nor was it using them). - xUnit implemented in Contrib via abstracts - this allow us to very quickly add any database provider to the rig in a very concise way. - Contrib unit tests fixed in various places - they were not parallel-runner friendly - Nuspecs removed, since they aren't used anymore (to eliminate confusion) - Removed speed tests for libraries that aren't on current versions of .Net (what would we be comparing?) - Perf tests moved to Dapper.Tests (consolidation from Dapper.DNX.Tests), but aren't activated yet (no define)
Side notes for others: ^ I updated the Appveyor builds to run tests now, once we're stable there I'll commit an appveyor.yml. Bonus: we can run MySQL and Postgres tests there, meaning the core library and contrib can test against many platforms via abstract-base test suites. See Contrib in the commit for how I'm already doing this. |
Looks great from here |
A full CoreCLR/DNX friendly conversion
@mgravell thanks for the eyes! I'll get the other good PRs merged in and try and get MySQL/Postgres tests working on Appveyor...those would be awesome to get many issues fixed here and be our workhorse. First though, I'll get them working locally. |
Project is no more compatible with Visual Studio 2012, I get right? |
@alexeyfadeev The sln right now is aimed at the core-clr tooling. I don't know if this is available on VS2012, but the command-line tools to build/pack/etc are freely available. For a walkthrough of how to do this: http://blog.marcgravell.com/2015/11/the-road-to-dnx-part-1.html (and 2/3), but essentially it boils down to:
|
Thanks, Build succeeded |
This eliminates the dual solutions and brings Contrib into the project.json fold.
Dapper.Contrib
andDapper.Tests.Contrib
(so tests appear at the end, no other reason vs.Dapper.Contrib.Tests
)Dapper.EntityFramework(.StrongName)
Dapper.Rainbow
Dapper.SqlBuilder
Dapper.Tests
(consolidation fromDapper.DNX.Tests
), but aren't activated yet (no define)