Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for MatchNamesWithUnderscores and ctor parameters #1394

Closed

Conversation

andreas-antoniou-cko
Copy link

Fix for #818

@agjini
Copy link

agjini commented Jan 7, 2020

Thanks for your fix. Looking the test it seems to work as expected. I allowed myself to make some comments on your code.

@NickCraver
Copy link
Member

Looking through this, I'm pretty sure it's a breaking change. It's not a new option, so people will have it on - the case of say ColumnName and Column_Name existing creates a conflict - anything differentiated by an underscore would be impacted by this. I can think of cases within the Stack Overflow API this would happen, as we use underscores or multiple underscores to differentiate some parameters there. In short: I don't think we can do this.

Perhaps how we map to constructors needs to be pluggable, like thinking in #722 for columns?

@NickCraver NickCraver changed the base branch from master to main June 20, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants