Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapper target netcoreapp1.0? #504

Closed
teilin opened this issue Apr 14, 2016 · 11 comments
Closed

Dapper target netcoreapp1.0? #504

teilin opened this issue Apr 14, 2016 · 11 comments

Comments

@teilin
Copy link

teilin commented Apr 14, 2016

Are there any plans of targeting netcoreapp1.0 for Dapper? I am using dnxcore50 and it works pretty well with Dapper, but I would love to be able to use the dotnetcli.

@mgravell
Copy link
Member

Definitely plans. And if you look at the commit history, I think the last
commit+revert was updating (and reverting) the refs to handle that. The
problem is: rc2 is a mess right now, and there is no single configuration
that builds cleanly from any package feed. When that exists: we'll
absolutely want to re-package and re-publish.

Marc
On 14 Apr 2016 7:47 a.m., "Teis Lindemark" [email protected] wrote:

Are there any plans of targeting netcoreapp1.0 for Dapper? I am using
dnxcore50 and it works pretty well with Dapper, but I would love to be able
to use the dotnetcli.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#504

@teilin
Copy link
Author

teilin commented Apr 14, 2016

Great.

@NickCraver
Copy link
Member

Just an FYI: there's now a netstandard branch with a clean build if you want to try it out.

@la-yumba
Copy link

With RC2 now officially released, it would be good to merge the netstandard branch.

It just needs netstandard1.3 to be changed to netstandard1.5

@NickCraver
Copy link
Member

I'll get with Marc soon as kids are out the door here and get NuGet updated - I don't follow your netstandard1.5 comment though, why would we need to change this?

@la-yumba
Copy link

this is what class libraries shoudl be written in according to the
documentation (as of today)
http://dotnet.github.io/docs/core-concepts/dnx-migration.html

Enrico Buonanno

email: [email protected]
skype ID: enrico.buonanno
Tel: +34 632 333 865

On Thu, May 19, 2016 at 12:04 PM, Nick Craver [email protected]
wrote:

I'll get with Marc soon as kids are out the door here and get NuGet
updated - I don't follow your netstandard1.5 comment though, why would we
need to change this?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#504 (comment)

@mgravell
Copy link
Member

The 1.5 is the minimum for targeting just .NET core. If you can use a
lower netstandard level, that's fine - and your library can be used on a
wider set on consumers. Using a lower number is fine. No change is required
here. At very worst case, we could choose to add both as explicit, but I
don't think that is required.

On 19 May 2016 at 12:28, Enrico [email protected] wrote:

this is what class libraries shoudl be written in according to the
documentation (as of today)
http://dotnet.github.io/docs/core-concepts/dnx-migration.html

Enrico Buonanno

email: [email protected]
skype ID: enrico.buonanno
Tel: +34 632 333 865

On Thu, May 19, 2016 at 12:04 PM, Nick Craver [email protected]
wrote:

I'll get with Marc soon as kids are out the door here and get NuGet
updated - I don't follow your netstandard1.5 comment though, why would we
need to change this?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
<
#504 (comment)


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#504 (comment)

Regards,

Marc

@henkmollema
Copy link
Contributor

You only need to target a higher .NETStandard if you need more API. Libraries should target the lowest as possible.

@la-yumba
Copy link

ok, I just migrated my own library to 1.5 as per docs, then in order to be
able to reference dapper I had to change it to 1.5 as well. (But I may well
be wrong, after all this is my 1st day grappling with this)

Enrico Buonanno

email: [email protected]
skype ID: enrico.buonanno
Tel: +34 632 333 865

On Thu, May 19, 2016 at 2:24 PM, Henk Mollema [email protected]
wrote:

You only need to target a higher .NETStandard if you need more API.
Libraries should target the lowest as possible.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#504 (comment)

@NickCraver
Copy link
Member

1.50-beta10 (supporting RC2) has been pushed to NuGet. Let us know if you have any issues!
https://www.nuget.org/packages/Dapper/1.50.0-beta10

@NickCraver
Copy link
Member

1.50-rc3 supporting RTM is now on NuGet, and it will become the stable version tomorrow night if we find no issues. Closing this issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants