Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update version of setuptools used to generate core package #1460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Jan 24, 2025

This updates setuptools version used in the build pipeline to v75.8.0, which includes pypa/setuptools@f285d01 and generates Metadata: 2.2 manifests for pypi

With this change, it becomes easier to manage flash-attn installation with uv. See astral-sh/uv#6607 (comment)

for some reason, uv always tries to build flash-attn during sync, even though it was not requested

This is expected and required. flash-attn ships as a source distribution, and only at Metadata-Version: 2.1, so you must ask the build backend for its dependencies per the spec -- which in turn requires that its build dependencies are already installed. There's really nothing we can do about this -- it's a problem with the package. They need to upgrade to Metadata-Version: 2.2.

For more details on the current workarounds, see the uv docs which feature a whole section on how to deal with issues trying to install flash-attn.

Screenshot 2025-01-23 at 6 18 24 PM

cc @tridao @charliermarsh

pip install ninja packaging setuptools wheel twine
pip install ninja packaging wheel twine
# Install latest setuptools with support for pypi metadata 2.2 (improved compat w/ uv)
pip install setuptools==75.8.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would use >= here but this is also reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants