Report error nodes in LSP #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edemaine
approved these changes
Feb 14, 2024
| errors, | ||
| }) | ||
|
|
||
| return Object.assign(result, { errors }) |
There was a problem hiding this comment.
Seeing this interface makes me wonder whether Civet.compile should directly return errors along with code and sourceMap, instead of (or in addition to?) modifying options. Is the issue that compile doesn't return an object when not requesting sourceMap?
There was a problem hiding this comment.
Yes, I think in the long run the errors can be returned alongside the sourceMap. When not requesting a sourceMap we should still throw because it only returns the compiled code as a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP now reports parse errors. Unfortunately they don't have location information yet so they will only appear at the top of the file. Eventually we can add location info to error nodes, apply the sourcemapping, update the LSP to check for this location, and then they will appear in the proper place.