Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Promise<void> in non-async function #815

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Fix Promise<void> in non-async function #815

merged 2 commits into from
Nov 23, 2023

Conversation

edemaine
Copy link
Collaborator

Fixes #814

We were setting modifier.async wrong in two places. 😅

STRd6
STRd6 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@STRd6 STRd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edemaine edemaine merged commit 61c8f2d into main Nov 23, 2023
3 checks passed
@edemaine edemaine deleted the promise-void-non-async branch November 23, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRd6 STRd6 STRd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promise<void> in non-async function
2 participants
@edemaine @STRd6