unplugin calls addWatchFile #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now ready for review! I moved the I did some testing and this fixes watch mode on Rollup and Webpack! It should also fix esbuild (and #773) once unjs/unplugin#345 gets merged. It still doesn't fix Vite (on Windows or Linux), for some reason I don't yet understand. But... progress? |
STRd6
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with unjs/unplugin#345, this will fix eventually #773.
I have tested this (
yarn linking to my unplugin fork), using the new esbuild example code.For now, it might fix watch mode on other build systems. But I wasn't able to test because e.g. Vite dev mode is currently broken (#775).
Update: The types don't work until the unplugin PR gets merged. So maybe we should wait for that.