Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX unbraced @ and @@ shorthand #507

Merged
merged 2 commits into from
Apr 15, 2023
Merged

JSX unbraced @ and @@ shorthand #507

merged 2 commits into from
Apr 15, 2023

Conversation

edemaine
Copy link
Collaborator

As suggested in #506 (review)

@edemaine edemaine temporarily deployed to build April 15, 2023 19:20 — with GitHub Actions Inactive
STRd6
STRd6 approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@STRd6 STRd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I have one more bonus feature request:

testCase """
    model@onClick
    ---
    <Component model@onClick />
    ---
    <Component onClick={model.onClick.bind(model)} />
  """

@edemaine edemaine temporarily deployed to build April 15, 2023 20:14 — with GitHub Actions Inactive
@edemaine
Copy link
Collaborator Author

I have one more bonus feature request:

I appreciate the encouragement. 😀 Coming in next PR! (Actually a reminder to do part 2 of #238.)

@edemaine edemaine merged commit 05e3c3c into main Apr 15, 2023
@edemaine edemaine deleted the bind-jsx branch April 15, 2023 20:16
@edemaine edemaine mentioned this pull request Apr 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRd6 STRd6 STRd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edemaine @STRd6