operator= assignment #301
Merged
operator= assignment #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edemaine
force-pushed
the
identifier-assignment
branch
from
e1e682d
to
69a09c1
Compare
STRd6
approved these changes
Jan 28, 2023
|
Looks good! |
|
It might be nice to see a test for something like: x not contains= y |
|
I don't think that currently works... Should it mean |
|
I'm not sure... but having a test documenting the current behavior would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transforms
x op= yintox = op(x, y), with the idea thatopis a user-defined binary infix operator.However, I have not restricted this to identifiers that have been blessed via
operator. It just works for all identifiers. I think this is a good idea, but it does have the following impact:But note that spaces are required before and after
y=, and the space before can't include a newline, which prevented falsely matching all existing tests. For example,x y=zstill meansx(y=z).If we think this is too risky, we could protect it behind blessed operators with a one-line change.