Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object comprehensions via loops in braces #1563

Merged
merged 11 commits into from
Nov 7, 2024
Merged

Object comprehensions via loops in braces #1563

merged 11 commits into from
Nov 7, 2024

Commits on Nov 2, 2024

  1. Basic Object Comprehension Support 

    Parses and transpiles object comprehension syntax proposed in issue DanielXMoore#439

Tested only in limited contexts, of the 4 tests added one is failing
    @peey
    peey committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ca2577d View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Rewrite to use IterationExpression 

    IterationExpressions now allowed in PropertyDefinition and assumed to be
object comprehensions

Code generation now handled in same way as for loop reduction logic

Revamp tests to suit the new implementation

All tests passing
    @peey
    peey committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8da1603 View commit details
    Browse the repository at this point in the history

  2. Cleanup and Polish 

    All tests passing
    @peey
    peey committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f87b488 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Support other loops + many more tests 

    All tests passing
    @peey
    peey committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1344706 View commit details
    Browse the repository at this point in the history

  2. Disallow for reductions and use immutability 

    Follows code review comments in DanielXMoore#1563
    @peey
    peey committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d698288 View commit details
    Browse the repository at this point in the history

  3. Add some reference documentation

    @peey
    peey committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7ac095e View commit details
    Browse the repository at this point in the history

  4. Relax whitespace 

    In line with other PropertyDefinition rules
    @peey
    peey committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    548bc91 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Prefer do...while and "loop" braceless loops 

    Prefer them over "do" and "loop" prop keys
    @peey
    peey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ef813cf View commit details
    Browse the repository at this point in the history

  2. Update object comprehensions docs 

    - Add example with a do...while loop
- Fix colon in an existing example
    @peey
    peey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    e833a67 View commit details
    Browse the repository at this point in the history

  3. Remove debugger statement

    @peey
    peey committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    24283e5 View commit details
    Browse the repository at this point in the history

  4. Prioritize {do} as object property, not iteration

    @edemaine
    edemaine committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a3fc074 View commit details
    Browse the repository at this point in the history