Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow |> throw #1517

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Allow |> throw #1517

merged 1 commit into from
Oct 27, 2024

Conversation

bbrk24
Copy link
Contributor

@bbrk24 bbrk24 commented Oct 26, 2024

Fixes #1513

Currently, always wraps it in an IIFE, since there's no easy way to tell whether it's in statement vs expression position.

STRd6
STRd6 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@STRd6 STRd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

In the future we can refine when we add IIFEs but this is much better than it not working at all.

@STRd6 STRd6 merged commit ca87ce3 into DanielXMoore:main Oct 27, 2024
4 checks passed
@edemaine edemaine mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRd6 STRd6 STRd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miscompile when attempting to |> throw
2 participants
@bbrk24 @STRd6