Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from ... import/export (reversed import/export) #1484

Merged
merged 2 commits into from
Oct 22, 2024
Merged

from ... import/export (reversed import/export) #1484

merged 2 commits into from
Oct 22, 2024

Conversation

edemaine
Copy link
Collaborator

Fixes #320
Fixes #800

Also cleanup some old import/export rules (merging type/no type for regular import, and merging explicit/implicit import in operator case)

STRd6
STRd6 reviewed Oct 21, 2024
View reviewed changes
test/export.civet Outdated Show resolved Hide resolved
STRd6
STRd6 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@STRd6 STRd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Maybe add a test case where we mix and match the from first / from last styles to see what happens.

@edemaine edemaine merged commit ec28c28 into main Oct 22, 2024
3 checks passed
@edemaine edemaine deleted the from-import branch October 22, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRd6 STRd6 STRd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python-style imports?
2 participants
@edemaine @STRd6