Improve project root detection in LSP #1470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at #1094. It seems to work better in development, but there are some aspects specific to dev vs. actual extension that might differ.
dist/lib
with atsconfig.json
(from newsource/tsconfig.json
). This helps the LSP figure out that the provided lib files are in their own project root.tsconfig.json
:node_modules/foo
directory, use that. This takes priority overtsconfig.json
becausefindConfigFile
searches in all ancestor directories, which could go very far up.I'm still getting the following errors about duplicate definitions. I'm not quite sure why; it seems like TypeScript is loading some
lib
s despite my asking it not to? But at least it's only seven errors, and it seems isolated to the.d.ts
file.