Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit type arguments, bulleted type tuples, multiple items in indented tuples #1391

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

edemaine
Copy link
Collaborator

@edemaine edemaine commented Sep 4, 2024

This started as an implementation of the idea that A B in a type context should parse as A<B>. But along the way I noticed that type tuples were woefully lacking compared to array literals.

  • Generally revamp type tuple parser to match array literal parser, in particular:
    • Support multiple types on one line of an indented tuple
    • Support bulleted type tuples
  • Support implicit type arguments, with space or indentation, similar to function calls

TODO: Documentation

Copy link
Contributor

@STRd6 STRd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just double check that the pop mutation in those 4 places is safe.

Thanks!

source/parser.hera Outdated Show resolved Hide resolved
@edemaine edemaine merged commit 9f7add5 into main Sep 4, 2024
3 checks passed
@edemaine edemaine deleted the implicit-type-arguments branch September 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants