Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent BinaryOp function shorthand from shadowing arrow functions. #1317

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Prevent BinaryOp function shorthand from shadowing arrow functions. #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/parser.hera
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,7 +2147,7 @@ FunctionExpression
}

# BinaryOp function shorthand
OpenParen:open BinaryOp:op CloseParen:close ->
!ArrowFunction OpenParen:open BinaryOp:op CloseParen:close ->
// (foo) doesn't need an arrow wrapper; just foo suffices
if (op.special && op.call && !op.negated) return op.call

Expand Down
15 changes: 15 additions & 0 deletions test/binary-op.civet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,6 +986,21 @@ describe "custom identifier infix operators", ->
a || foo(b, c) && d
"""

testCase """
shadowed in arguments
---
operator foo (a, b)
a

(foo) => arr[foo]
---
function foo (a, b) {
return a
};

(foo) => arr[foo]
"""

describe "custom precedence", ->
testCase """
same as symbol
Expand Down
Loading