Brace block improvements, including & statements

[edemaine]

Fixes #1176

I unified a place where we were manually bracing a block into a call to braceBlock. But they differed in the closing brace: the new use ended with } while other instances ended with }. I'm somewhat tempted to switch to the spaced version throughout, which would lead to changes like this:

switch x
  {a: y, b: y}
    y
↓↓↓
   if(typeof x === 'object' && x != null && 'a' in x && 'b' in x) {
     const {a: y1, b: y2} = x;
     const y = [y1, y2];
-    y }
+    y}

But this would involve changing ~70 tests. Do you think it's worth it?

[STRd6]

Looks good!

As for the space before the closing brace I've actually been leaning towards not inserting any spaces/newlines to keep the generated code as close as possible to the original source. There are fewer $loc tokens to keep track of and it usually doesn't look too bad visually since it is closer to the original.

[edemaine]

Good point; makes sense. I looked at unifying braceBlock in the other direction and I get only two failing tests:

-(x): void => { console.log(x)}
+(x): void => { console.log(x) }

-const ignore = <T, U>(a: T, b: U) : void => { null}
+const ignore = <T, U>(a: T, b: U) : void => { null }

It's just a bit uglier that I hesitate to do it... but it would simplify the code slightly (no second argument to braceBlock). I guess I'll go for it.