Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an external formatter API to be able to launch Run with custom formatters #29

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pierre-Sassoulas
Copy link
Collaborator

Was necessary to tests the args parsing with the default value handled by something else than argparse. As we decided in #15 to let the coverage fall a little we could still use it to provide an API later on.

@Pierre-Sassoulas Pierre-Sassoulas added enhancement New feature or request blocked labels Jan 8, 2022
@coveralls
Copy link

coveralls commented Jan 8, 2022

Pull Request Test Coverage Report for Build 1671483567

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 100.0%

Totals Coverage Status
Change from base Build 1671482333: 0.5%
Covered Lines: 219
Relevant Lines: 219

💛 - Coveralls

@DanielNoord DanielNoord marked this pull request as draft January 8, 2022 14:15
@DanielNoord
Copy link
Owner

I'm converting this to draft as I wonder if during development towards 1.0 will find other necessary attributes and methods needed for formatters. For example, a way to set formatter specific options.

I think this would be a really good feature to put in 1.1. As in: make sure we get 1.0 to be compliant with both PEPs and that we are happy with how everything is set up, and then allow for some additional customisation with plugin formatters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants