Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use environment variables or AWS EC2/Lambda configuration #13

Closed
wants to merge 3 commits into from
Closed

use environment variables or AWS EC2/Lambda configuration #13

wants to merge 3 commits into from

Conversation

arturojain
Copy link
Contributor

#12

DanielHindi
DanielHindi reviewed Apr 20, 2017
View reviewed changes
Copy link
Owner

@DanielHindi DanielHindi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be two pull requests with similar changes I assume this is the one you'd like me to consider, correct?

@arturojain
Copy link
Contributor Author

@DanielHindi yes, I tried to create to branches, one with the doc changes and one with the usage of env vars, in fact this one has an error and I will close it, sorry.

@arturojain arturojain closed this Apr 20, 2017
@arturojain arturojain mentioned this pull request Apr 20, 2017
Closed
@arturojain arturojain deleted the env-vars branch April 20, 2017 17:44
@arturojain arturojain mentioned this pull request Apr 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHindi DanielHindi DanielHindi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturojain @DanielHindi