-
Notifications
You must be signed in to change notification settings - Fork 175
add elispPath command to bootstrap elisp code from ghc-mod installation #492
base: master
Are you sure you want to change the base?
Conversation
If we want this to land on MELPA we have to move it to |
Another improvement would be to check to make sure that ghc-mod understands the |
Perhaps then we would move the current elisp code out of elisp/ and move the bootstrap code into there. |
What's up with that Makefile? Is that a template you got from somewhere? |
I got it from the |
Oh rite xD, I could swear I've never seen that thing before. I'm not really sure why we need that especially the |
I just added some stuff to deal with versions and ./scripts/bump.sh. Not sure if it works because I don't have GNU sed or tac here right now (on OS X). |
elisp-bootstrap/ghc-mod.el
Outdated
"*The command name of \"ghc-mod\"") | ||
(defvar ghc-bootstrapped nil) | ||
|
||
(defun ghc-bootstrap () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just prefix all symbols with ghc-mod instead of ghc I'd like to move away from the elisp package being called ghc, might as well start now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good plan, I'll do that when I get back from lunch.
You know I'm not so sure I like the approach. If we go with this we'll be stuck with people having (ghc-bootstrap) in their init files forever. Our current entrypoint Anyways since we're already stuck with |
Also have a look at this (master...DanielG:dev-elisp-simple) branch I started doing some cleanup ages ago maybe you can base this on that branch. Dunno if it's useful though. |
One problem at a time I guess? We could do something like this now, and work on isolating the effects and such for ghc-mod-mode later. Renaming things sound fine to me. Should we still rename |
Per #358 this adds an elispPath command which prints out the elisp directory in the ghc-mod installation. Adds a separate elisp-bootstrap directory with elisp code to call ghc-mod with elispPath and load the real code.
I don't really know what I'm doing in elisp but this worked for me. Here's what is in my initialization for emacs:
Presumably you'd be able to take the elisp-boostrap dir and upload it to MELPA which would work for all future versions of ghc-mod. Possible enhancements would include better error reporting, in particular if ghc-mod isn't found then it should tell the user to install ghc-mod and ensure that it's on the PATH.