-
Notifications
You must be signed in to change notification settings - Fork 175
Start cleaning up ghc-mod's Emacs frontend #325
Conversation
Should I merge this right now? I think it is better to merge this after version 5.0.0 is released. |
No, sorry I edited the original message to say don't merge it until after 5.0, you probably just missed that :) |
Sorry, it's my fault. I understand. |
I think that it's time to merge this but this cannot be automatically merged. |
Since some important pull requests have been merged. We should release ghc-mod 5.0.1.2 and merge this after then, right? |
Sure. I'll pull it into master next time I feel like doing elisp stuff :) |
@DanielG Are you still planning on updating this? Or would you prefer that someone else take over? |
@david-christiansen It's still on my TODO list but university has me a bit short on time, so feel free to work on this :) |
@DanielG @kazu-yamamoto what is the status of this work? I am interested in the customization mentioned in #302. |
On ice currently as I have no time for elisp work right now. |
- `ghc-mod-mode` is now a minor mode providing ghc-mod's functionality - Backwards compatibility is provided by calling `(ghc-mod-mode)` from `ghc-init` and (eventually) warning users that used the `ghc-*-key` variables to change keybindings since now a minor-mode specific keymap is used. - I also intend to rename most non-user facing functions and varaibles to use the `ghc-mod-` prefix rather than `ghc-`
ghc-mod-mode
is now a minor mode providing ghc-mod's functionality(ghc-mod-mode)
fromghc-init
and (eventually) warning users that used theghc-*-key
variables to change keybindings since now a minor-mode specific keymap
is used.
to use the
ghc-mod-
prefix rather thanghc-
This is a development preview, don't merge until after the 5.0 release.
Still to do:
ghc-mod-check
. @kazu-yamamoto some pointers with this one would be appreciatedghc-*-key
were changed from defaults.customize
facilities