Skip to content
This repository has been archived by the owner on Apr 25, 2020. It is now read-only.

Start cleaning up ghc-mod's Emacs frontend #325

Closed
wants to merge 14 commits into from
Closed

Start cleaning up ghc-mod's Emacs frontend #325

wants to merge 14 commits into from

Conversation

DanielG
Copy link
Owner

@DanielG DanielG commented Aug 16, 2014

  • ghc-mod-mode is now a minor mode providing ghc-mod's functionality
  • Backwards compatibility is provided by calling (ghc-mod-mode) from
    ghc-init and (eventually) warning users that used the ghc-*-key
    variables to change keybindings since now a minor-mode specific keymap
    is used.
  • I also intend to rename most non-user facing functions and varaibles
    to use the ghc-mod- prefix rather than ghc-

This is a development preview, don't merge until after the 5.0 release.

Still to do:

  • Undo effects of ghc-mod-check. @kazu-yamamoto some pointers with this one would be appreciated
  • Present warning messages when ghc-*-key were changed from defaults.
  • Fix installation instruction in ghc.el
  • Document migration for users
  • Add support for Emacs' customize facilities

@kazu-yamamoto
Copy link
Collaborator

Should I merge this right now? I think it is better to merge this after version 5.0.0 is released.

@DanielG
Copy link
Owner Author

DanielG commented Aug 18, 2014

No, sorry I edited the original message to say don't merge it until after 5.0, you probably just missed that :)

@kazu-yamamoto
Copy link
Collaborator

Sorry, it's my fault. I understand.

@kazu-yamamoto
Copy link
Collaborator

I think that it's time to merge this but this cannot be automatically merged.
@DanielG Would you take care of this by yourself?

@kazu-yamamoto
Copy link
Collaborator

Since some important pull requests have been merged. We should release ghc-mod 5.0.1.2 and merge this after then, right?

@DanielG
Copy link
Owner Author

DanielG commented Aug 29, 2014

Sure. I'll pull it into master next time I feel like doing elisp stuff :)

@david-christiansen
Copy link

@DanielG Are you still planning on updating this? Or would you prefer that someone else take over?

@DanielG
Copy link
Owner Author

DanielG commented Nov 4, 2014

@david-christiansen It's still on my TODO list but university has me a bit short on time, so feel free to work on this :)

@bmjames
Copy link

bmjames commented Apr 12, 2015

@DanielG @kazu-yamamoto what is the status of this work? I am interested in the customization mentioned in #302.

@DanielG
Copy link
Owner Author

DanielG commented Apr 12, 2015

On ice currently as I have no time for elisp work right now.

NightRa and others added 14 commits May 28, 2015 00:22
- `ghc-mod-mode` is now a minor mode providing ghc-mod's functionality

- Backwards compatibility is provided by calling `(ghc-mod-mode)` from
  `ghc-init` and (eventually) warning users that used the `ghc-*-key`
  variables to change keybindings since now a minor-mode specific keymap
  is used.

- I also intend to rename most non-user facing functions and varaibles
  to use the `ghc-mod-` prefix rather than `ghc-`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants