Fix Unity structs drawn in property drawer #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the issues discussed in #66 where certain Unity structs cannot be shown well via a catch-all property field. This PR resolves that by adding specific checks for those types and displays them how they are edited normally elsewhere in the editor.
Testing
I've created a test script and scene at
Assets/PR Test Content/UnityStructTestScene.unity
where References can be viewed for each of the affected types as well as Variables/Collection assets for those same types in that folder. Try the inspector for each of these and switch them from constant to variable and back in the case of References.Changes
Removed redundant call to set rect height
elementHeightCallback
, which in this case isGetElementHeight
. Removed paddingGetElementHeight
so that a single line item does not appear stretched.Modified collection, reference editors
Added internal extension methods for Vector4, Quaternion