Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created AudioClip Variable, Reference, and Collection types #64

Conversation

jeffcampbellmakesgames
Copy link
Contributor

Summary

This PR adds Variable, Reference, and Collection types for the native Unity AudioClip class. This should make it easier to hook up and design data-driven elements for audio.

Testing

I've created a test scene at Assets/PR Test Content/AudioClipTestScene.unity that has an example script setup with a button to show this would be used. If UseRandomClickNoise is checked, when the button is clicked a random AudioClip will be played from a AudioClipCollection asset, otherwise a AudioClip from an AudioClipReference will be used.

image

Changes

Created AudioClip Variable, Reference, and Collection Types

  • Created Variable, Reference, and Collection Types for the native Unity AudioClip ref type.

jzapdot added 2 commits April 19, 2019 09:51
* Created Variable, Reference, and Collection Types for the native Unity AudioClip ref type.
* This is content for PR testing only and can be discarded after review/approval.
@jeffcampbellmakesgames
Copy link
Contributor Author

I did not add custom icons for this commit.

@DanielEverland DanielEverland added this to the Release 1.6.0 milestone Apr 20, 2019
@DanielEverland
Copy link
Owner

Merged.
@jeffcampbellmakesgames Do you know what I'm doing wrong seeing as GitHub doesn't register automatically?

To discard your test commit I use git reset --hard
When adding icons or fixing minor issues I commit into your branch. Should I do this in master after merging the PR?

@jeffcampbellmakesgames
Copy link
Contributor Author

Merged.
@jeffcampbellmakesgames Do you know what I'm doing wrong seeing as GitHub doesn't register automatically?

To discard your test commit I use git reset --hard
When adding icons or fixing minor issues I commit into your branch. Should I do this in master after merging the PR?

I'm not sure, is the PR closing when the test commit is discarded? Any more details that you can share on that would be helpful. I've added to or changed branches before that were in a PR without them closing.

@jeffcampbellmakesgames jeffcampbellmakesgames deleted the feat/audio_clip_variable branch April 22, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants