Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in TypedGameEventEditor #116

Merged

Conversation

jzapdot
Copy link
Contributor

@jzapdot jzapdot commented Feb 21, 2020

##Summary
Fixed a bug in the TypedGameEventEditor where a property change for its serialized type would not apply those changes to the serialized object. This would result in the value never being applied to that derived type of GameEventBase. We discovered this when creating a GameEventBase<T> where T was an Enum and the selecting a different value than the default would not be set.

Unity 2019.3.0f6

Testing

Create an Enum-derived type such as the example below and create a GameEventBase class instance of it. In this example, One would be the default value set and toggling the value of the event in the inspector to something different should apply.

public enum FooType
{
    One,
    Two,
    Three
}

* Fixed a bug in the TypedGameEventEditor where a property change for its type would not apply those changes to the serialized object.
@DanielEverland DanielEverland added this to the Release 1.6.5 milestone Feb 22, 2020
@DanielEverland DanielEverland merged commit 7970e37 into DanielEverland:master Feb 22, 2020
@DanielEverland
Copy link
Owner

Thanks again for the PR :)

@jeffcampbellmakesgames
Copy link
Contributor

Thanks again for the PR :)

No problem, always glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants