Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter decodeing hard codeed in openFolder function #13

Open
LudwigWen opened this issue Apr 9, 2021 · 3 comments
Open

parameter decodeing hard codeed in openFolder function #13

LudwigWen opened this issue Apr 9, 2021 · 3 comments

Comments

@LudwigWen
Copy link

using:

  • onedrive_tray --onedrive-path onedrive --onedrive-args "--monitor --confdir=~/.config/my-new-config"
    not working:

  • searchIng QStringList should use regulär expressions instead and not adding +1 to notfoundValue==-1

  • Missing --confdir-Parameter should use ~/.config/onedrive/config as default

  • filePathes starting with ~ should be replaced by QDir::homePath()

PS:
think about create new process:

  • onedrive --display-config
    when --confdir-Parameter exists:
  • onedrive --display-config --confdir=~/.config/my-new-config
@DanielBorgesOliveira
Copy link
Owner

Hi @LudwigWen ,

onedrive_tray --onedrive-path onedrive --onedrive-args "--monitor --confdir=~/.config/my-new-config"
not working:

As onedrive_tray calls onedrive client, you have to indicate the full path of the onedrive client.
The right way to call the program is onedrive_tray --onedrive-path [full path to your one client. E.g /usr/local/bin/onedrive.] --onedrive-args "--monitor --confdir=~/.config/my-new-config".

searchIng QStringList should use regulär expressions instead and not adding +1 to notfoundValue==-1

I did not understand what you want to say here. Can you explain me in more details?

Missing --confdir-Parameter should use ~/.config/onedrive/config as default

This parameter is part of onedrive client developed by @abraunegg. I am not sure but I think this is the default behavior of the program.

filePathes starting with ~ should be replaced by QDir::homePath()

The path we use in onedrive_tray is the path of onedrive client and this path have to be absolute as we use this path to call the program.

PS:
think about create new process:

onedrive --display-config
when --confdir-Parameter exists:
onedrive --display-config --confdir=~/.config/my-new-config

Thank for the suggestion. This will be on the TODO list.

@abraunegg
Copy link

@LudwigWen , @DanielBorgesOliveira
When using --confdir option, it must be used like this:

 ./onedrive --confdir '~/.config/onedrive-personal/'

or

 ./onedrive --confdir '/full/path/to/.config/onedrive-personal/'

The ~ will be expanded by the application as best as possible if it exists.

If --confdir is omitted, the application will use ~/.config/onedrive/ as a default

My suggestion here is that 'onedrive_tray' make no assumption regarding --confdir and should pass all elements of --onedrive-args to the onedrive client as-is and let the 'onedrive' client interpret the options & generate any errors if found.

@LudwigWen
Copy link
Author

LudwigWen commented Apr 26, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants