Dans98 klipper velocity pid #47
Merged
+87
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sherman <[email protected]> Signed-off-by: Vinzenz Hassert <[email protected]>
bwnance
force-pushed
the
dans98_klipper_velocity_pid
branch
from
5da4f9b
to
2f2a79f
Compare
rogerlz
approved these changes
Aug 24, 2023
|
@bwnance do you want me to directly submit a pr here for fixing the calibration code? I'm pretty much done with upstream at this point. |
|
@dans98 that would be awesome :) |
|
I will have a pr ready tonight or tomorrow for the updates for pid_calibration, do we need to follow this commit format/policy here? |
|
@dans98 ah, we should update that. We've been pretty lax with it, so don't worry about it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream PR: Klipper3d/klipper#6272