Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubaracek pwm scaling #44

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Kubaracek pwm scaling #44

merged 3 commits into from
Aug 22, 2023

Conversation

bwnance
Copy link
Contributor

@bwnance bwnance commented Aug 11, 2023

kubaracek and others added 2 commits August 22, 2023 14:52
Scale value for fan input based on fan's `min_power` and `max_power`.
As an example, when fan's min_power is set to `0.2`, requesting 1% of fan should translate to roughly `0.2`
This makes it possible to operate fans such as CPAP which generally need
quite high min_power (between 16-30%) operatable at 1%

This also renamed off_below to min_power

Signed-off-by: Jakub Racek <[email protected]>
@bwnance bwnance force-pushed the kubaracek_pwm_scaling branch 2 times, most recently from 95fa472 to 02cb5ae Compare August 22, 2023 18:55
@bwnance bwnance requested a review from rogerlz August 22, 2023 18:56
Copy link
Contributor

@rogerlz rogerlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🏌️

@bwnance bwnance merged commit c2a9a5f into master Aug 22, 2023
2 checks passed
@rogerlz rogerlz deleted the kubaracek_pwm_scaling branch August 27, 2023 17:40
@Gethe Gethe mentioned this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants