Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control_mpc: add MPC control law #333

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

dalegaard
Copy link
Contributor

This adds MPC control law to main branch.

Has been extensively tested on feature/mpc_experimental branch but would like to get to main so we can get wider testing. Would appreciate final code review.

Let me know if we need to add any extra docs.

Best regards,
Lasse

@dalegaard dalegaard requested a review from a team as a code owner July 8, 2024 17:32
@YanceyA
Copy link
Contributor

YanceyA commented Jul 10, 2024

edit: PR #334 Now Open

@dalegaard I am working on a doc [MPC.md] update from my own branch. It should be ready for PR this weekend. Let me know if you specifically have any areas which need to be added, changed or improved.

Rough TODO:
-Adjust docs to have "experimental section" with bed function details. Remove references to BED in main section of the doc for clarity.
-Add PTC temp-power reference table
-Add any relevent discord notes, specifically around ambient temp parameter.
-Remove ambient temp parameter from primary config section to optional parameters to mitigate people placing too much emphasis on it
-Add temp wait macro
-Clean up feed forward macro section
-Add notes that MPC controls block temp and not sensor temp to mitigate user confusion.

@rogerlz rogerlz force-pushed the feature/mpc_experimental_pr branch from ed70bb1 to 0aac830 Compare July 10, 2024 22:25
@rogerlz
Copy link
Contributor

rogerlz commented Jul 10, 2024

thanks @YanceyA. I added a bit of doc to the config reference. Let me know if you want me to correct or add anything else there

Copy link
Contributor

@YanceyA YanceyA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger, a few small comments on the config. Otherwise it all looks great.

README.md Outdated Show resolved Hide resolved
docs/Config_Reference.md Show resolved Hide resolved
@rogerlz rogerlz force-pushed the feature/mpc_experimental_pr branch from de482df to d9a1ea6 Compare July 15, 2024 09:46
@rogerlz
Copy link
Contributor

rogerlz commented Jul 15, 2024

Roger, a few small comments on the config. Otherwise it all looks great.

thanks for the suggestions

@dalegaard dalegaard force-pushed the feature/mpc_experimental_pr branch from d9a1ea6 to 27b0e74 Compare July 27, 2024 22:50
@rogerlz rogerlz force-pushed the feature/mpc_experimental_pr branch from 27b0e74 to 069caa6 Compare August 11, 2024 09:14
@rogerlz rogerlz merged commit 08a9eed into DangerKlippers:master Aug 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants