gcode_macro: Enable jinja2.ext.do extension #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't mind 👍 |
|
Should that not be at least mentioned in the documentation somewhere? Maybe even with the nice little danger marker if/once that gets approved? While I don't know what exactly that extension does I am pretty sure it would cause makros not to be directly portable to regular klipper. |
Piezoid
force-pushed
the
r3Fuze-jinja_do_ext
branch
from
8277760
to
ca98cff
Compare
|
@chestwood96 it just adds support for a new |
|
I will add a section to the macro commands templates doc though |
Fisheiyy
force-pushed
the
r3Fuze-jinja_do_ext
branch
from
ca98cff
to
827a493
Compare
bwnance
force-pushed
the
r3Fuze-jinja_do_ext
branch
from
827a493
to
4d9a7f6
Compare
This adds a 'do' tag that works like a normal expression but ignores the return value. Useful for avoiding running the output of an expression as a command. Signed-off-by: Morten Lindhardt <[email protected]>
bwnance
force-pushed
the
r3Fuze-jinja_do_ext
branch
from
4d9a7f6
to
b9cff9d
Compare
rogerlz
approved these changes
Aug 27, 2023
rogerlz
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR: Klipper3d/klipper#5149
@r3Fuze please let us know if you are against having your changes merged into danger-klipper!