Curve Fan Control #193
Merged
Curve Fan Control #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeanon
force-pushed
the
temperature_fan_curve_control
branch
from
6f71898
to
02cdd8c
Compare
rogerlz
reviewed
Apr 25, 2024
test/klippy/curve_control.cfg
Outdated
Comment on lines
58
to
60
| point1: 50.0, 0.0 | ||
| point2: 55.0, 0.5 | ||
| point3: 60.0, 1.0 |
There was a problem hiding this comment.
what do you think about:
points:
- 50.0, 0.0
- 55.0, 0.5
- 60.0, 1.0
And looping through it to allow a dynamic number of points?
rogerlz
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another control algorithm to a temperature fan called curve.
It's basically the same thing you use in your pc, you jsut define a temperature curve and off you go.
Should be pretty self explanatory but please let me know if my documentation makes sense to you :)
Feedback is welcome as always