Merge pull request #2 from Azure/master

merge from master

.editorconfig

@@ -0,0 +1,14 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+[*.json]
+indent_style = space
+indent_size = 2
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[cSpell.json]
+indent_size = 4
+indent_style = space

.gitattributes

@@ -0,0 +1,2 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text=auto

.github/CONTRIBUTING.md

@@ -2,7 +2,7 @@
 First, thank you for contributing to Azure specs repository! Swagger specs are the basis for generating Azure SDKs in multiple different languages, Azure CLIs for interacting with the services, and can provide documentation for these services.
 
 ## Basics
-If you're a spec author looking for information about all of of the repositories and steps in the pipeline, go to the [adx-documentation-pr](https://github.com/Azure/adx-documentation-pr) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo.
+If you're a spec author looking for information about all of the repositories and steps in the pipeline, go to the [adx-documentation-pr](https://github.com/Azure/adx-documentation-pr) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo.
 
 ## Table of Contents
 [Before starting](#before-starting)
@@ -86,7 +86,7 @@ Use the git tools you have available to you, such as amend, rebase, etc.
 
 
 ## Review process
-We review spec PRs to maintain a high bar of quality for all products that will be generated from these specs (including SDKs in all languages, CLIs and documentation). It's critical that spec files are both sytactically and semantically correct, as well as conform to common patterns that make it possible to generate SDKs and CLIs that are usable for customers. Since specs are the base input for all of these products, the review process starts with PRs to this repository. Please refer to [Swagger Review Process](https://github.com/Azure/adx-documentation-pr/wiki/Swagger-Review-Process) for more details.
+We review spec PRs to maintain a high bar of quality for all products that will be generated from these specs (including SDKs in all languages, CLIs and documentation). It's critical that spec files are both syntactically and semantically correct, as well as conform to common patterns that make it possible to generate SDKs and CLIs that are usable for customers. Since specs are the base input for all of these products, the review process starts with PRs to this repository. Please refer to [Swagger Review Process](https://github.com/Azure/adx-documentation-pr/wiki/Swagger-Review-Process) for more details.
 
 The expectation is that every spec in a PR will be correct JSON, syntactically correct, will semantically agree with the service it applies to, and will follow the recommended patterns.
 
@@ -95,7 +95,7 @@ A spec file must be valid JSON, according to the [JSON specification](https://to
 
 #### Semantic correctness
 Your spec file must correctly represent your service. Even if a spec passes all of the rules listed above, it might not accurately describe the service that it is intended to describe. This could include 
-- Incorrect schemas for responses or requests (both missing and superfluous properities)
+- Incorrect schemas for responses or requests (both missing and superfluous properties)
 - Missing operations
 - Missing parameters (especially required ones)
 - etc (this list is not comprehensive)

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,15 +1,17 @@
-This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
+### Latest improvements:
+<i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow. 
+</i><br>
+### Contribution checklist:
+- [ ] I have reviewed the [documentation](https://github.com/Azure/azure-rest-api-specs#basics) for the workflow.
+- [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.
+- [ ] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps.
+### ARM API Review Checklist
+- [ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories. 
+- adding/removing APIs.
+- adding/removing properties.
+- adding/removing API-version. 
+- adding a new service in Azure.
 
-### PR information
-- [ ] The title of the PR is clear and informative.
-- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).
-- [ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
-- [ ] If applicable, the PR references the bug/issue that it fixes.
-- [ ] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).
-
-### Quality of Swagger
-- [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).
-- [ ] My spec meets the review criteria:
-  - [ ] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).
-  - [ ] The spec follows the guidelines described in the [Swagger checklist](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md) document.
-  - [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.
+Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
+- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. 
+Please follow the link to find more details on [API review process](https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderOnboardingAPIRevieworkflow.html).

.gitignore

@@ -44,6 +44,10 @@ Icon
 # Thumbnails
 ._*
 
+# Ignore repo files
+/scripts/stostools/restoredPackages
+/scripts/stostools/restoredpackages
+
 # Files that might appear in the root of a volume
 .DocumentRevisions-V100
 .fseventsd
@@ -72,7 +76,6 @@ SdkCodeGen
 # Visual Studio #
 .settings/
 .vs/
-.vscode/
 /app.js
 *.suo
 *.user
@@ -100,3 +103,15 @@ AutoRest.*
 output/*
 errors.txt
 warnings.txt
+
+# VS Code files
+.vscode/*
+!.vscode/settings.json
+!.vscode/tasks.json
+!.vscode/launch.json
+!.vscode/extensions.json
+
+*.js
+*.d.ts
+*.js.map
+*.d.ts.map

.vscode/extensions.json

@@ -0,0 +1,6 @@
+{
+    "recommendations": [
+        "EditorConfig.EditorConfig",
+        "docsmsft.docs-authoring-pack"
+    ]
+}

.vscode/launch.json

@@ -0,0 +1,27 @@
+{
+  // Use IntelliSense to learn about possible attributes.
+  // Hover to view descriptions of existing attributes.
+  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "Mocha Tests",
+      "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
+      "args": [
+        "--timeout",
+        "999999",
+        "--colors",
+        "${workspaceFolder}/test/syntax.js"
+      ],
+      "internalConsoleOptions": "openOnSessionStart"
+    },
+    {
+      "type": "node",
+      "request": "launch",
+      "name": "Launch Program",
+      "program": "${file}"
+    }
+  ]
+}

.vscode/settings.json

@@ -19,5 +19,6 @@
             ],
             "url":"https://raw.githubusercontent.com/Azure/autorest/master/schema/composite-swagger.json"
         }
-    ]
+    ],
+    "typescript.tsdk": "node_modules\\typescript\\lib"
 }

CODEOWNERS

@@ -14,7 +14,7 @@
 /specification/consumption/ @kjeur @panda-wang
 /specification/containerinstance/ @samkreter
 /specification/containerregistry/ @djyou
-/specification/containerservices/ @mboersma
+/specification/containerservice/ @mboersma
 /specification/cosmos-db/ @dmakwana
 /specification/customer-insights/ @tjlvtao
 /specification/datafactory/ @zhangyd2015
@@ -29,7 +29,7 @@
 /specification/eventgrid/ @kalyanaj
 /specification/eventhub/ @v-ajnava
 /specification/features/ @stankovski
-/specification/graphrbac/ @stankovski
+/specification/graphrbac/ @lmazuel @yugangw-msft @amarzavery
 /specification/hdinsight/ @pulkittomar @wawon-msft
 /specification/insights/ @gucalder
 /specification/intune/ @vrmurthy01
@@ -73,3 +73,4 @@
 /specification/timeseriesinsights/ @sandshadow
 /specification/trafficmanager/ @allencal @hrkulkarmsft
 /specification/web/ @lukaszstem @naveedaz @nking92
+/profile/ @shahabhijeet

README.md

@@ -7,7 +7,9 @@
 This repository is the canonical source for REST API specifications for Microsoft Azure.
 
 ## Basics
-If you're a spec author looking for information about all of of the repositories and steps in the pipeline, go to the [adx-documentation-pr](https://github.com/Azure/adx-documentation-pr) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo. 
+If you're a spec author looking for information about all of the repositories and steps in the pipeline, go to the [adx-documentation-pr](https://github.com/Azure/adx-documentation-pr) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo. 
+
+<b>Latest improvement:</b><i> Microsoft employees can try out our new experience at [OpenAPI Hub](https://aka.ms/openapihub) - online experience for using our validation tools and finding your workflow.</i>
 
 Please check the [announcements page](https://github.com/Azure/azure-rest-api-specs/wiki/Announcements) for any new updates since your last visit.
 

arm-compute/quickstart-templates/aliases.json

@@ -14,7 +14,7 @@
           "CentOS":{
             "publisher":"OpenLogic",
             "offer":"CentOS",
-            "sku":"7.3",
+            "sku":"7.5",
             "version":"latest"
           },
           "CoreOS":{
@@ -26,7 +26,7 @@
           "Debian":{
             "publisher":"credativ",
             "offer":"Debian",
-            "sku":"8",
+            "sku":"9",
             "version":"latest"
           },
           "openSUSE-Leap": {
@@ -38,24 +38,30 @@
           "RHEL":{
             "publisher":"RedHat",
             "offer":"RHEL",
-            "sku":"7.3",
+            "sku":"7-RAW",
             "version":"latest"
           },
           "SLES":{
             "publisher":"SUSE",
             "offer":"SLES",
-            "sku":"12-SP2",
+            "sku":"15",
             "version":"latest"
           },
           "UbuntuLTS":{
             "publisher":"Canonical",
             "offer":"UbuntuServer",
-            "sku":"16.04-LTS",
+            "sku":"18.04-LTS",
             "version":"latest"
           }
         },
 
         "Windows":{
+          "Win2019Datacenter":{
+            "publisher":"MicrosoftWindowsServer",
+            "offer":"WindowsServer",
+            "sku":"2019-Datacenter",
+            "version":"latest"
+          },
           "Win2016Datacenter":{
             "publisher":"MicrosoftWindowsServer",
             "offer":"WindowsServer",

arm-compute/quickstart-templates/swagger.json

@@ -242,7 +242,7 @@
         },
         "outputs": {
           "type": "object",
-          "description": "Gets or sets key/value pairs that represent deploymentoutput."
+          "description": "Gets or sets key/value pairs that represent deployment output."
         },
         "providers": {
           "type": "array",
@@ -344,7 +344,7 @@
       "required": [
         "uri"
       ],
-      "description": "Entity representing the reference to the deployment paramaters."
+      "description": "Entity representing the reference to the deployment parameters."
     },
     "Provider": {
       "properties": {