Dryon execution ba681ed72d #18

DanLiu2Intel · 2024-08-05T10:14:56Z

Details:

item1
...

Tickets:

ticket-id

DanLiu2Intel · 2024-08-07T09:35:03Z

src/plugins/intel_npu/tools/compile_tool/main.cpp

@@ -413,6 +421,10 @@ static bool parseCommandLine(int* argc, char*** argv) {
        throw std::invalid_argument("Target device name is required");
    }

+    if (!FLAGS_dryon.empty()) {
+        intel_npu::update_dryon_flag(true);


need test the flag status.
Does there need a function to check flag status?

DanLiu2Intel · 2024-08-07T09:36:56Z

src/plugins/intel_npu/tools/compile_tool/CMakeLists.txt

+# find_package(openvino::npu_al) #感觉这部分不需要使用
+file(GLOB_RECURSE DRYONEXECUTION_HEADERS ${PROJECT_SOURCE_DIR}/src/plugins/intel_npu/src/*.hpp)
+message("==========2============")
+message("@@@@${DRYONEXECUTION_HEADERS}@@@@")


remove this part

DanLiu2Intel · 2024-08-07T09:37:06Z

src/plugins/intel_npu/tools/compile_tool/CMakeLists.txt

@@ -15,16 +20,21 @@ endif()
 #
 # Define the target
 #
-
+message("${CMAKE_CURRENT_SOURCE_DIR} is what???")
+message("${PROJECT_SOURCE_DIR} is what???")


remove this part

DanLiu2Intel · 2024-08-07T09:37:53Z

src/plugins/intel_npu/tools/compile_tool/CMakeLists.txt

 ov_add_target(ADD_CPPLINT
              TYPE EXECUTABLE
              NAME ${TARGET_NAME}
              ROOT ${CMAKE_CURRENT_SOURCE_DIR}
+              INCLUDES
+              /home/dl5w0502/vpux/openvino/src/plugins/intel_npu/src/al/include/
+              ${PROJECT_SOURCE_DIR}/src/plugins/intel_npu/src/al/include/


keep one in here. test which one is useful.

github-actions · 2024-08-07T09:38:15Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

@@ -0,0 +1,19 @@
+#pragma once
+
+


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

#include "update_dryon_flag.hpp"

DanLiu2Intel · 2024-08-07T09:40:34Z

src/plugins/intel_npu/src/plugin/src/plugin.cpp

+         {false,
+          ov::PropertyMutability::RO,
+          [&](const Config&) {
+              return _metrics->GetInternalSupportedProperties();


this part can be replaced by static std::vector<ov::PropertyName> Metrics_internalSupportedProperties = {ov::internal::caching_properties.name()};

is not it?

DanLiu2Intel · 2024-08-07T09:42:06Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+
+#include <iostream>
+#include "update_dryon_flag.hpp"
+#include "/home/dl5w0502/vpux/openvino/src/plugins/intel_npu/src/plugin/include/plugin.hpp" 


this part need to be fix with relative path.

DanLiu2Intel · 2024-08-07T09:42:08Z

src/plugins/intel_npu/src/al/include/update_dryon_flag.hpp

+
+
+#include <iostream>
+#include "/home/dl5w0502/vpux/openvino/src/plugins/intel_npu/src/plugin/include/plugin.hpp" 


this part need to be fix with relative path.

DanLiu2Intel · 2024-08-07T09:42:43Z

src/plugins/intel_npu/src/al/CMakeLists.txt

@@ -14,6 +14,7 @@ set_target_properties(${TARGET_NAME} PROPERTIES EXPORT_NAME npu_al)
 target_include_directories(${TARGET_NAME}
    PUBLIC
        $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+        # ${CMAKE_CURRENT_SOURCE_DIR}/../plugin/include


how can add relative path of plugin/include?

DanLiu2Intel · 2024-08-07T09:58:49Z

To be implemented: 1)new compile_tool for dry on execution (Low reuse)
2)pass extra param to OV_DEFINE_PLUGIN_CREATE_FUNCTION(Plugin, version) (compile_tool how to pass extra param to here? the method is similar to this method. so this method not make sense.)
plugin() use extra param to initilize inside class plugin_imp. and inherit issue.
3)the update function is this position suitable？

github-actions · 2024-08-08T03:41:01Z

src/plugins/intel_npu/src/al/include/update_dryon_flag.hpp

+extern bool flag_Dryon;
+bool get_dryon_flag();
+void update_dryon_flag(bool flag);
+}


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

}

} // namespace intel_npu

github-actions · 2024-08-08T03:41:01Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+
+
+#include <iostream>
+#include "update_dryon_flag.hpp"


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

#include "update_dryon_flag.hpp"

github-actions · 2024-08-08T03:41:01Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+bool get_dryon_flag(){
+    if(flag_Dryon)
+        std::cout << " (get)!!!! true"<< std::endl;


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

bool get_dryon_flag(){

if(flag_Dryon)

std::cout << " (get)!!!! true"<< std::endl;

bool get_dryon_flag() {

if (flag_Dryon)

std::cout << " (get)!!!! true" << std::endl;

github-actions · 2024-08-08T03:41:01Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+    if(flag_Dryon)
+        std::cout << " (get)!!!! true"<< std::endl;
+    else
+        std::cout << " (get)!!!! flase"<< std::endl;


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

std::cout << " (get)!!!! flase"<< std::endl;

std::cout << " (get)!!!! flase" << std::endl;

github-actions · 2024-08-08T03:41:01Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+    if(flag_Dryon)
+        std::cout << " !!!! true"<< std::endl;


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

if(flag_Dryon)

std::cout << " !!!! true"<< std::endl;

if (flag_Dryon)

std::cout << " !!!! true" << std::endl;

github-actions · 2024-08-08T03:41:01Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+        std::cout << " !!!! flase"<< std::endl;
+


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

std::cout << " !!!! flase"<< std::endl;

std::cout << " !!!! flase" << std::endl;

github-actions · 2024-08-08T03:41:01Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+    if(flag_Dryon)
+        std::cout << " !!!! true"<< std::endl;


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

if(flag_Dryon)

std::cout << " !!!! true"<< std::endl;

if (flag_Dryon)

std::cout << " !!!! true" << std::endl;

github-actions · 2024-08-08T03:41:02Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+        std::cout << " !!!! flase"<< std::endl;
+


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

std::cout << " !!!! flase"<< std::endl;

std::cout << " !!!! flase" << std::endl;

github-actions · 2024-08-08T03:41:02Z

src/plugins/intel_npu/src/al/src/update_dryon_flag.cpp

+    std::printf("     --------after update, %d\n", get_dryon_flag());
+}
+
+}


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

}

} // namespace intel_npu

github-actions · 2024-08-08T03:41:02Z

src/plugins/intel_npu/src/plugin/include/plugin.hpp

@@ -54,6 +53,10 @@ class Plugin : public ov::IPlugin {
                                    const ov::AnyMap& properties) const override;

 private:
+    void init();
+    void initPluginWithoutBackend();
+    std::map<std::string, std::tuple<bool, ov::PropertyMutability, std::function<ov::Any(const Config&)>>> Generate_supportedPropert();


[reviewdog-suggester] _{reported by reviewdog 🐶}

Suggested change

std::map<std::string, std::tuple<bool, ov::PropertyMutability, std::function<ov::Any(const Config&)>>> Generate_supportedPropert();

std::map<std::string, std::tuple<bool, ov::PropertyMutability, std::function<ov::Any(const Config&)>>>

Generate_supportedPropert();

DanLiu2Intel · 2024-08-08T03:45:22Z

Why is the flag not passed correctly
dl5w0502@dl-desk:~/vpux/openvino/bin/intel64/Release$ ./compile_tool -m /home/dl5w0502/vpux/myCID/data/add_abc.xml -d NPU -c /home/dl5w0502/vpux/openvino/testConfigandData/MLIR.conf -dryon true
OpenVINO Runtime version ......... 2024.4.0
Build ........... 2024.4.0-16207-7c414c5e88b-DryonExecution_ba681ed72d
Parsing command-line arguments
(get)!!!! flase
,(1), compile_tool fl=0
(get)!!!! flase
--------before update, 0
!!!! flase
!!!! true
(get)!!!! true
--------after update, 1
(get)!!!! true
,(2), compile_tool fl=1
Checking FLAGS_LOG_LEVEL
Reading model
Performing reshape
Configuring model pre & post processing
Printing Input and Output Info from model
Network inputs:
A : f32 / [...] / [1]
B : f32 / [...] / [1]
C : f32 / [...] / [1]
Network outputs:
Y/sink_port_0 : f32 / [...] / [1]
Parsing configuration file
Compiling model
(get)!!!! flase
flag_Dryon is flase
(get)!!!! flase
=========>init plugin normally
(get)!!!! flase
<compile_tool222>flag_Dryon is flase
(get)!!!! flase
=========>compile_model normally
Writing into file - add_abc.blob
Done. LoadNetwork time elapsed: 160 ms

github-actions · 2024-08-23T01:16:45Z

This PR will be closed in a week because of 2 weeks of no activity.

github-actions bot removed category: TF FE category: TFL FE category: PyTorch FE category: tools category: transformations category: dockerfiles category: C API category: LP transformations category: AUTO BATCH category: IR FE category: PDPD FE category: docs_snippets labels Aug 7, 2024

first to build

eabdee5

DanLiu2Intel commented Aug 7, 2024

View reviewed changes

github-actions bot reviewed Aug 7, 2024

View reviewed changes

DanLiu2Intel commented Aug 7, 2024

View reviewed changes

build 1

7c414c5

DanLiu2Intel commented Aug 7, 2024

View reviewed changes

github-actions bot reviewed Aug 8, 2024

View reviewed changes

build success, but can not pass correct flag to plugin constructor

ca9b72f

github-actions bot added the Stale label Aug 23, 2024

DanLiu2Intel closed this Aug 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dryon execution ba681ed72d #18

Dryon execution ba681ed72d #18

DanLiu2Intel commented Aug 5, 2024

DanLiu2Intel Aug 7, 2024

DanLiu2Intel Aug 7, 2024

DanLiu2Intel Aug 7, 2024 •

edited

Loading

DanLiu2Intel Aug 7, 2024

github-actions bot Aug 7, 2024

DanLiu2Intel Aug 7, 2024

DanLiu2Intel Aug 7, 2024

DanLiu2Intel Aug 7, 2024

DanLiu2Intel Aug 7, 2024

DanLiu2Intel commented Aug 7, 2024 •

edited

Loading

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

github-actions bot Aug 8, 2024

DanLiu2Intel commented Aug 8, 2024

github-actions bot commented Aug 23, 2024



		#include <iostream>
		#include "/home/dl5w0502/vpux/openvino/src/plugins/intel_npu/src/plugin/include/plugin.hpp"

	std::cout << " (get)!!!! flase"<< std::endl;
	std::cout << " (get)!!!! flase" << std::endl;

	std::cout << " !!!! flase"<< std::endl;
	std::cout << " !!!! flase" << std::endl;

	std::map<std::string, std::tuple<bool, ov::PropertyMutability, std::function<ov::Any(const Config&)>>> Generate_supportedPropert();
	std::map<std::string, std::tuple<bool, ov::PropertyMutability, std::function<ov::Any(const Config&)>>>
	Generate_supportedPropert();

Dryon execution ba681ed72d #18

Dryon execution ba681ed72d #18

Conversation

DanLiu2Intel commented Aug 5, 2024

Details:

Tickets:

DanLiu2Intel Aug 7, 2024

Choose a reason for hiding this comment

DanLiu2Intel Aug 7, 2024

Choose a reason for hiding this comment

DanLiu2Intel Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

DanLiu2Intel Aug 7, 2024

Choose a reason for hiding this comment

github-actions bot Aug 7, 2024

Choose a reason for hiding this comment

DanLiu2Intel Aug 7, 2024

Choose a reason for hiding this comment

DanLiu2Intel Aug 7, 2024

Choose a reason for hiding this comment

DanLiu2Intel Aug 7, 2024

Choose a reason for hiding this comment

DanLiu2Intel Aug 7, 2024

Choose a reason for hiding this comment

DanLiu2Intel commented Aug 7, 2024 • edited Loading

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot Aug 8, 2024

Choose a reason for hiding this comment

DanLiu2Intel commented Aug 8, 2024

github-actions bot commented Aug 23, 2024

DanLiu2Intel Aug 7, 2024 •

edited

Loading

DanLiu2Intel commented Aug 7, 2024 •

edited

Loading